Improve handling of attachment urls and filenames

Carla Dragorequested to merge
carlad-gl/fix-url-file-path-handling into master

What does this MR do and why?

Improve handling of attachment urls and filenames

Fixes instance where urls start with url attachment paths but do not actually link to attachments, and sanitizes attachment filenames to avoid filename errors.

References

Screenshots or screen recordings

I am not able to QA for an unsupported filename as GitHub seem to now sanitize filenames eg "data compliance certificate.pdf" becomes "data.compliance.certificate.pdf" when uploaded

spaces

Source Destination
source destination

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #582947 (closed)

Edited by Carla Drago

Merge request reports