Track MR approvals from the Review Drawer
What does this MR do and why?
Adds a tracking event - mr_approved_from_review_drawer - to the Review panel.
Screenshots or screen recordings
N/A, telemetry only.
How to set up and validate locally
- Have an MR in a project
- If you created the MR, ensure that the merge request settings for your project allow approval by the MR author
- Visit the MR and create a draft comment
- Click the "Your review (#)" button in the tabs header
- Select the "Approve" radio button
- Click "Submit review"
- Note the request sent to
/api/v4/usage_data/track_eventwith the eventmr_approved_from_review_drawer- Note the correct values provided to the event:
reviewer(whether you are an assigned reviewer or not),comments(how many draft comments there were in this review), andsummary(whether you entered a comment). - Repeat as necessary to test other values (for example, when you approve but have a different reviewer status).
- Note the correct values provided to the event:
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Thomas Randolph