Skip to content

Fix excessive Redis calls for new HSET/HMGET diffs cache

What does this MR do?

Before this change, we were submitting multiple HMGET calls to Redis unnecessarily when reading or writing to the cache, reaching incredibly high timings when enabling the hset_redis_diff_caching feature flag.

This MR fixes that by using a memoized method.

Closes #39133 (closed)

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Oswaldo Ferreira

Merge request reports