Ensure space between review comment lines
What does this MR do?
For #32770 (closed).
This change "adds" missing space between paragraphs in a batch (review) pending discussion (note).
It does this by removing a rule that had previously been squashing all p elements to their siblings with 0 margin.
Maybe notable: No matter how much whitespace is added (e.g. hit the enter key 6 times for 5 blank lines), the backend processor always returns a single break (represented by a new paragraph element). This may be frustrating for some users in edge cases where they really do want that much whitespace. This is standard behavior in markdown, but may be surprising to people who don't know that.
Screenshots
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
~~Label as security and @ mention @gitlab-com/gl-security/appsec~~ -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team