Pass organization_id to SnippetsFinder in internal services

Chen Zhangrequested to merge
duo-edit-20251126-030316 into master

What does this MR do and why?

This MR updates internal services to pass organization_id to SnippetsFinder, positioning it immediately after the current_user parameter. This prepares for organization_id to become a required parameter in the future.

The organization_id is obtained from Current.organization.id and passed consistently across all internal services that use SnippetsFinder.

This is MR 3 of 3 in a planned rollout:

MR 1: Web Controllers (4 files) - MERGED ✅

Priority: HIGH - User-facing changes

Files:

  • app/controllers/dashboard/snippets_controller.rb
  • app/controllers/explore/snippets_controller.rb
  • app/controllers/projects/snippets_controller.rb
  • app/controllers/users_controller.rb

Status: !212826 (merged)

MR 2: API & GraphQL (3 files) - IN REVIEW

Priority: HIGH - External integrations

Files:

  • lib/api/snippets.rb
  • lib/api/project_snippets.rb
  • app/graphql/resolvers/concerns/resolves_snippets.rb

Status: !213784

MR 3: Internal Services (4 files) - THIS MR

Priority: MEDIUM - Backend functionality

Files:

  • app/finders/notes_finder.rb
  • app/services/projects/autocomplete_service.rb
  • app/services/snippets/count_service.rb
  • lib/gitlab/snippet_search_results.rb

Why last? Internal services with less direct user impact.

Specs updated in this MR:

  • spec/finders/notes_finder_spec.rb - added :with_current_organization
  • spec/services/projects/autocomplete_service_spec.rb - added :with_current_organization
  • spec/services/snippets/count_service_spec.rb - added :with_current_organization
  • spec/lib/gitlab/snippet_search_results_spec.rb - added :with_current_organization

References

Related to #570399 Follow-up to !213784

Screenshots or screen recordings

N/A - Backend changes only

How to set up and validate locally

  1. Ensure the Current.organization middleware is enabled (should be default)
  2. Run the updated specs to verify they pass: 
    bundle exec rspec spec/finders/notes_finder_spec.rb
bundle exec rspec spec/services/projects/autocomplete_service_spec.rb
bundle exec rspec spec/services/snippets/count_service_spec.rb
bundle exec rspec spec/lib/gitlab/snippet_search_results_spec.rb

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports