Skip to content

Add banner section in admin area for Puma-Rugged notices

Qingyu Zhao requested to merge create-puma-rugged-suboptimal-config-checker into master

What does this MR do?

For issue #119335 (closed)

Because rugged calls do IO and CPU intensive work while holding the Ruby GVL, combine Puma and Rugged could possibly degrade performance in some environment. So we want to detect this configuration and warn admin. During Puma opt-in phase, we also want to notice administrator Puma is used, and Puma thread>1.

This MR:

  • create a class to detect several puma/rugged related configs:
    • Puma is the application server
    • Puma multi-threaded(thread>1) in use
    • Rugged enabled and multi-threaded(thread>1) Puma in use (#35371 (comment 255171241))
  • add banners section in admin area to show the detected Puma-Rugged notices.

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Yorick Peterse

Merge request reports