[18.5] Fix /admin/sidekiq not loading CSS assets in Cloud Native GitLab

What does this MR do and why?

This backports !213239 (merged) to 18-5-stable-ee.

In GitLab 14.3, we added a workaround in !70113 (merged) to disable the Sendfile interface for Sidekiq assets. This workaround deleted the HTTP_X_SENDFILE_TYPE header, which signaled to Rack not to use the Sendfile interface.

Sidekiq bundles its own CSS and JavaScript assets in the gem, and registers these via Rack::Static By default, Rack::Sendfile will use the Sendfile interface if available to offload the sending to Workhorse However, Workhorse might not have these assets, as they are bundled with the installed Ruby gem.

However, with the upgrade to Rack v2.2.20+, HTTP_X_SENDFILE_TYPE is ignored. Rails will always use the Sendfile interface if the body responds to to_path. In this case, Rack::Static uses Rack::Files, which responds to to_path.

To work around this issue, we remove that header and read the file content directly to restore the body that Rack::Sendfile emptied.

Relates to https://gitlab.com/gitlab-com/gl-infra/production/-/issues/20862

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has succeeded, or if it has failed, investigate the failures. If you determine the failures are unrelated, you may proceed. If you need assistance investigating, reach out to a Software Engineer in Test in #s_developer_experience.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Stan Hu

Merge request reports

Loading