Skip to content

Fix duplicate spec files

Scott Stern requested to merge fix-duplicate-karma-jest-files into master

What does this MR do?

As a result of !16336 (merged), the pipeline is failing because we have spec files in both jest and karma. This MR moves utils_spec to jest and then move tests in ee/spec/frontend/approvals/components/modal_rule_create_spec.js to rule_form_spec and consolidated logic into the karma spec file for rule_form_spec.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports