Skip to content

Settings app for Docker Container Retention and Expiration policies

Nicolò Maria Mezzopera requested to merge 15398-vue-settings-form into master

What does this MR do?

This MR adds a new component to handle the settings form, vuex actions mutations and state to handle the data flow and make API calls.

All the work around this MR is behind feature flag, this is just the frontend part and backend is developed in another MR

See this issue for a list of all the MRs that are a part of this work: #15398 (closed)

What this MR cover:

  • adding of a new vue component to handle the form
    • form is made with a11y compliance in mind
  • updating the store with new props
  • updating the copy according to new changes
  • add editProject method to api.js
  • unit tests

What this MR does not cover

  • connection to API ( not yet ready )
  • feature tests ( to be done when frontend and backend are connected )

Screenshots (Updated at 16/12/2019)

Collpased

Screenshot_2019-12-16_at_14.51.08

Expanded

Screenshot_2019-12-16_at_14.51.16

Filled with correct validation

Screenshot_2019-12-16_at_14.51.46

Invalid valiation

Screenshot_2019-12-16_at_14.51.37

Screencapture (Not updated)

screen-capture__19_

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Part of #15398 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports