Skip to content

Remove actions buttons if theres no designs

Jarek Ostrowski requested to merge remove-action-buttons-if-no-designs into master

What does this MR do?

Removes the action buttons (design destroyer, add designs) from the latest version if there are no designs. These buttons don't make sense to show if there's no designs.

Before After
Screen_Shot_2019-12-04_at_10.31.04_AM Screen_Shot_2019-12-04_at_10.31.14_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

To reproduce:

  • Upload a design
  • Delete that design
  • In the current version, there will be no designs, but the buttons will show.
  • Upload another design to confirm that the buttons show up when hasDesigns in true.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

cc @cdybenko

Edited by 🤖 GitLab Bot 🤖

Merge request reports