Skip to content

Adjust iframe csp for tracing page

Ryan Cobb requested to merge rc/adjust_iframe_csp_for_tracing into master

What does this MR do?

Embedding an iframe was introduced in this MR !17912 (merged) with the intent of users being able to have an iframe of jaeger embedded directly in gitlab.

Our CSP policy only allows iframes to the following srcs "'self' https://www.google.com/recaptcha/ https://www.recaptcha.net/ https://content.googleapis.com https://content-compute.googleapis.com https://content-cloudbilling.googleapis.com https://content-cloudresourcemanager.googleapis.com"

This MR allows iframes to ANY src but only for the tracing show page.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports