Update approvers before resetting approvals on MRs
requested to merge 33998-merge-requests-in-busy-repositories-can-create-race-conditions-and-allow-codeowners-checks-to into master
What does this MR do?
Move the update_approvers before reset_approvals_for_merge_requests to help prevent a possible race condition. This may or may not solve the issue, but is a small refactor regardless.
Closes #33998 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Closes #33998 (closed)
Edited by Grzegorz Bizon