Refactor delete upstream modal component to fetch registries
What does this MR do and why?
Refactor delete upstream modal component to fetch registry names
Update edit upstream component based on refactored component
Changelog: changed
EE: true
Context
- This feature was initially added in Show associated registries before maven upstrea... (!203775 - merged)
- We want to reuse this component in other places, like the upstreams list page view.
- Based on the UX suggestion #576227 (comment 2836370349) we decided
we can bring in a loader state for the registry names in the modal
- An MR based on this MR which adds the functionality to the upstreams list page for context: Adds delete upstream action to upstream list view (!211361 - merged)
References
Screenshots or screen recordings
| Before | After |
|---|---|
| Follow screenshots in !203775 (merged) |
|
How to set up and validate locally
- Go to a group
- Go to
Deploy -> Virtual Registry - Create a new maven registry
- Click on the
Add upstreambutton - The required fields are
name,url. For the URL, you can usehttps://repo.maven.apache.org/maven2/ - Click on
Create upstreamand observe the list update. - Click on the pencil icon for the newly created upstream. This should take you to the edit upstream page.
- Click on
Delete upstreambutton should show modal with the registry names listed. - Create at least 5 more maven registries. Link the same upstream to each of the virtual registry.
- Clicking on
Delete upstreambutton should show modal with the registry names listed & truncated.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #576227
Edited by Rahul Chanila
