Skip to content

Resolve "Move Analytics out of "More" in top navbar"

What does this MR do?

This MR merges the instance statistics and analytics sidebar items. It also removes the 2 items from the More navbar dropdown and places them into an analytics shortcut option on the navbar.

A simple sounding change, but a lot to consider as this differs between CE and EE;

  • CE
    • Rename the Instance Statistics to Analytics for consistency.
    • Display nav link if user has access to instance statistics features
    • Display all available CE features in sidebar
  • EE
    • Display the analytics nav link IF
      • User has access to instance statistics features OR
      • Any EE specific analytics features are enabled
    • Display sidebar items based on availability and access to features
      • Display links to enabled EE specific analytics features for all users
      • Display links to instance statistics features if a user has access to them

Screenshots

Desktop

Before

Instance statistics sidebar Analytics sidebar More dropdown Navbar
Screenshot_2019-12-03_at_13.15.02 Screenshot_2019-12-03_at_13.15.56 Screenshot_2019-12-03_at_13.16.04 Screenshot_2019-12-03_at_13.16.18

After

Merged sidebar More dropdown Navbar
Screenshot_2019-12-10_at_12.59.39 Screenshot_2019-12-03_at_14.19.42 Screenshot_2019-12-10_at_12.52.03

Mobile

After

Sidebar More dropdown Navbar
Screenshot_2019-12-10_at_12.57.09 Screenshot_2019-12-11_at_15.34.27 Screenshot_2019-12-10_at_12.57.28

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Issue

#36017 (closed)

Edited by Brandon Labuschagne

Merge request reports