Edit a violation comment
What does this MR do and why?
Add the ability to edit a violation comment.
The edit button is behind a feature flag (compliance_violation_comments_ui).
References
Related to #541095 (closed)
Screenshots or screen recordings
| Before | After | Notes |
|---|---|---|
|
|
Edit button, edited status |
|
Edit form displays upon clicking edit button | |
|
|
Also fixed this spacing error when there is no activity yet |
How to set up and validate locally
- You need to have a group with Ultimate license.
- Required data, you need to have a project compliance violation to view:
- You need to have at least one project under the group, atleast one audit event related to the project.
- Also, have at least one compliance framework in the group, the framework should have atleast one compliance control.
- The framework should be applied to the project.
- Now create a compliance violation entry in the database by running following command in the rails console:
ComplianceManagement::Projects::ComplianceViolation.create(project_id: <project_id>, namespace_id: <namespace_id>, audit_event_id: <audit_event_id>, compliance_requirements_control_id: <compliance_requirements_control_id>, status: 0, audit_event_table_name: 0)
- Navigate to the project that now has the violation, and go to
path/to/project/-/security/compliance_violations/<violation-id> - In rails console enable the feature flag
Feature.enable(:compliance_violation_comments_ui) - Verify that the form renders on the violation page
- Verify that comment preview works
- Submit a comment
- Verify that the note shows up on the violation details page, with an image if added
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Scott Hampton




