Skip to content

Introduced the snippets_vue feature flag

Denys Mishunov requested to merge 34820-snippets-view-vue-feature-flag into master

What does this MR do?

It's the first step in the plan for #34820 (closed). Hence this should not close original issue (though merging in master should happen)

The MR introduces support for snippets_vue feature flag for refactoring of a snippet view into Vue.

Testing

  1. In browser: open a snippet
  2. The snippet will be rendred
  3. Enable feature flag via rails console:
Feature.enable(:snippets_vue)
  1. Reload the same snippet's view
  2. The content part of the page will be gone now: replaced by a DOM element that will serve as Vue application's container later.
With FF disabled With FF enabled
Screenshot_2019-12-03_at_01.31.41 Screenshot_2019-12-03_at_01.33.08

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

References #34820 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports