Remove consolidate_mr_analytics_in_shared_dashboards feature flag
What does this MR do and why?
Remove consolidate_mr_analytics_in_shared_dashboards feature flag and related code.
- Adds redirect from the old MR analytics page to the new MR analytics dashboard.
- Remove
Analyze > Merge request analyticsfrom the sidebar in all cases - Removes old controller, HAML view, custom page SCSS and JS entrypoint
- Update references to point to the new page
- Removes the feature flag
Additional frontend code will be removed in a follow-up MR. Some of the code was shared between the old/new apps, so to keep the diff simple I wanted to do it separately
References
Screenshots or screen recordings
| Before | After |
|---|---|
|
|
How to set up and validate locally
- Navigate to any project
- Confirm that
Analyze > Merge request analyticsdoes not appear in the side menu - Test the redirect from old MR analytics page
- Visit the old merge request analytics URL:
http://gdk.test:3000/flightjs/flight/-/analytics/merge_request_analytics - Verify it redirects to
http://gdk.test:3000/flightjs/flight/-/analytics/dashboards/merge_request_analytics
- For any project, navigate to
Analyze > Analytics dashboards - Open the
Merge request analyticsdashboard and verify that it loads successfully - Open the
Value streams dashboardand verify that clicking theDeploys,Merge request throughputandMedian time to mergemetric names all link to the new dashboard
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Related to #568363 and #546036 (closed)
Edited by Alex Pennells

