Skip to content

Respond with 204 no content when pages domain does not exist

Grzegorz Bizon requested to merge feature/gb/internal-pages-domain-no-content into master

What does this MR do?

This merge request changes the internal API we have to communicate with GitLab Page, to meet the contract between GitLab Pages and GitLab API.

On the Pages side we expect that the API is going to respond with 204 No Content when a domain has not been found to avoid confusion between 404 and invalid API URL.

We are also using query parameters in the API to find a domain, so 204 is semantically correct too.

Conformity

/cc @nicholasklick @krasio

Edited by Kamil Trzciński

Merge request reports