Skip to content

Remove disabled usage on GlPaginate

What does this MR do and why?

Remove disabled usage on GlPaginate

The disabled prop was only used in a few places on GlPaginate, and in all three cases disabling the entire component is not necessary anyway. This branch was intended as an integration branch for gitlab-org/gitlab-services/design.gitlab.com!5244 (merged), but the necessary changes can be made in advance of a release of the DS.

References

See also gitlab-org/gitlab-services/design.gitlab.com#2796 (closed)

Screenshots or screen recordings

Before After
Screen Recording 2025-10-27 at 17.36.21.mov Screen Recording 2025-10-27 at 17.33.09.mov

How to set up and validate locally

In order to test this, you will need to create several project access tokens programmatically from the rails console. Run bundle exec rails console and then paste in the following, which will create 201 inactive tokens and 201 active ones (each page is 100 items long).

project = Project.find_by_full_path('flightjs/Flight')

# Find one existing project bot user for this project
bot_user = project.users.where(user_type: :project_bot).first

if bot_user
  (1..201).each do |i|
    # Create inactive token
    PersonalAccessToken.create!(
      user: bot_user,
      name: "Test Token #{i} (Inactive)",
      scopes: ['api'],
      expires_at: 30.days.ago
    )
    
    # Create active token
    PersonalAccessToken.create!(
      user: bot_user,
      name: "Test Token #{i} (Active)",
      scopes: ['api'],
      expires_at: 30.days.from_now
    )
  end
  
  puts "Created 402 project access tokens for user: #{bot_user.username}"
else
  puts "No project bot users found for this project"
end

After that

  1. Visit https://gdk.test:3000/flightjs/Flight/-/settings/access_tokens
  2. You will see that both the active and inactive token tables are paginated
  3. Move between pages of each
  4. You will see that the pagination does not lose focus and functions properly when transitioning from page to page.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading