Skip to content

Unconfigured analyzer with no build is valid

What does this MR do and why?

Unconfigured analyzer with no build is valid

Add an exception to the analyzer status validator:
Consider an analyzer with status "NOT_CONFIGURED" still valid even when
it has no buildId because an unconfigured analyzer won't have a build

Why? I keep seeing these console warnings when testing locally:

index.js:24 [Vue warn]: Invalid prop: custom validator check failed for prop "item".

found in

---> <ProjectToolCoverageIndicator> at /Users/miranda/gdk/gitlab/ee/app/assets/javascripts/security_inventory/components/project_tool_coverage_indicator.vue
       <ToolCoverageCell> at /Users/miranda/gdk/gitlab/ee/app/assets/javascripts/security_inventory/components/tool_coverage_cell.vue
         <BTr>
           <BTbody>
             <BTableLite>
               <GlTableLite> at /Users/miranda/gdk/gitlab/node_modules/@gitlab/ui/src/components/base/table_lite/table_lite.vue
                 <SecurityInventoryTable> at /Users/miranda/gdk/gitlab/ee/app/assets/javascripts/security_inventory/components/security_inventory_table.vue
                   <Dashboard> at /Users/miranda/gdk/gitlab/ee/app/assets/javascripts/security_inventory/components/inventory_dashboard.vue
                     <App> at /Users/miranda/gdk/gitlab/ee/app/assets/javascripts/security_inventory/components/app.vue
                       <Root>

... but it seems like these analyzers should still be considered valid objects. 🤔

References

Screenshots or screen recordings

Before After

How to set up and validate locally

  1. go to a group => Secure => Security inventory
  2. have at least one project visible there with analyzers configured, but without SECRET_DETECTION_SECRET_PUSH_PROTECTION or CONTAINER_SCANNING_FOR_REGISTRY configured
  3. open the developer tools console and verify that there are no [Vue warn]: Invalid prop: custom validator check faileds

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Miranda Fluharty

Merge request reports

Loading