Skip to content

Project Export rate limits

George Koltsov requested to merge georgekoltsov/add-rate-limit-to-exports into master

What does this MR do?

This MR adds rate limits to ProjectsController#export & ProjectsController#download_export actions to prevent chain requesting/downloading exports.

Reason: https://gitlab.com/gitlab-org/gitlab/issues/37490

Current limits:

  1. Export request - 1 per 5 minutes
  2. Export downloads - 10 per 10 minutes

These rate limits are also applied to API endpoints.

Screenshots

image

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports