Rspec system test state fixes
What does this MR do and why?
In !204309 (merged) we upgraded the version of Chrome to 138 (from 123), even after the numerous pipelines we ran in that MR, there seems to be state issues in some system tests which have been exacerbated by the upgrade.
This MR tries to fix some of those issues, by using let! rather than let_it_be_with_reload, the issues are documented in https://gitlab.com/gitlab-org/gitlab/-/issues/577767+
References
11767644505, 11767928858, 11768080927, 11768176402, 11768218446, 11768605512, 11768604611, 11768604553, 11769164783, 11769164716, 11769164950
Screenshots or screen recordings
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Jay McCure