Update auto_duo_code_review_enabled setting to use new cascading worker
What does this MR do and why?
- This MR updates the existing
auto_duo_code_review_enabledcascading settings to use sidekiq workers that were added in this MR: Adds sidekiq workers to cascade ai settings (!204464 - merged) -
auto_duo_code_review_enabledcascading setting was introduced in !201399 (merged) and !201832 (merged) - Relevant discussion: !202745 (comment 2737935402)
How to set up and validate locally
Prerequisites:
- Make sure the AI features are enabled locally using this guide
- Use
http://localhost:3000/gitlab-duogroup which already hasDuo Enterpriseadd-on andduo_features_enabled: true - Enable feature flag in Rails console:
Feature.enable(:cascading_auto_duo_code_review_settings)
Validate group level:
-
As group owner, go to Settings > General > Merge requests→GitLab Duo Code Reviewand enable the setting -
Create a subgroup/project → Go to subgroup (or project)'s settings → Auto review checkbox should be enabled and editable (inherited but can be changed). Disable and enable again. -
Go back to the group and disable GitLab Duo Code Reviewand verify that the subgroup/project level settings also get disabled
Validate instance level:
-
As admin, go to Admin Area > Settings > General → GitLab Duo Code Reviewand enable the setting -
Create a group/project → Go to group (or project)'s settings → Auto review checkbox should be enabled and editable (inherited but can be changed). Disable and enable again. -
Go back to the admin setting and disable GitLab Duo Code Reviewand verify that the subgroup/project level settings also get disabled
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Kinshuk Singh