SPP Dark Launch - Timeout before the time runs out
What does this MR do and why?
This MR adds timeout protection to SPP dark launch to prevent it from exceeding the available time budget during git push operations.
During dark launch, SPP runs in the background to collect data without blocking pushes. However, if the validation takes too long, it can consume the entire time budget allocated for git hooks, potentially causing the push operation to timeout.
This change:
- Checks if there's sufficient time remaining (at least 10 seconds) before starting the secrets check
- Wraps dark launch in a
Timeout.timeout
block using the available time minus a 10-second buffer - Logs an error and skips SPP if insufficient time remains
This ensures SPP dark launch never causes git push timeouts, maintaining the principle that SPP should never block legitimate code from being pushed.
References
Screenshots or screen recordings
Before | After |
---|---|
How to set up and validate locally
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Craig Smith