Skip to content

[18.5] Downgrade redis-rb gem to v5.4.0

What does this MR do and why?

This backports !209191 (merged) to 18-5-stable-ee.

In https://github.com/redis/redis-rb/pull/1312, redis v5.4.1 was updated to translate RedisClient::ConnectionError to Redis::ConnectionError to avoid leaking the underlying exception. However, ActionCable v7.1.5.2 relied on this behavior and only reconnected if RedisClient::ConnectionError were raised. As a result, if the Redis server terminated an idle connection, the Puma thread would raise an exception and cause the worker process to restart.

Rails has since been updated to handle this in https://github.com/rails/rails/pull/55359. The fix has been committed to the Rails 7-1-stable branch but not yet released.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Stan Hu

Merge request reports

Loading