Skip to content

Add empty region when group metrics are missing

Miguel Rincon requested to merge 34121-group-level-no-data-store into master

What does this MR do?

Display when a panel group is in an empty state in the dashboard

The metrics dashboard didn't let users know when data was missing from a panel. This change is the first step to know why data is missing.

This change makes use of getter to calculate if the a panel group of the dashboard should be displayed as empty.

Pending:

Note:

Our issue #34121 (closed) defines multiple empty states to let the use know what went wrong. This is a first pass that should be followed up with more detailed implementation.

Screenshots

In devices

1 2 3 4
Screen_Shot_2019-12-04_at_2.58.57_PM Screen_Shot_2019-12-04_at_2.57.39_PM Screen_Shot_2019-12-04_at_2.57.27_PM Screen_Shot_2019-12-04_at_3.26.51_PM

Loading flow

2019-12-04_15.54.40

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #34121 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports