Skip to content

Add ability to edit Group Hooks

What does this MR do?

  • Add ability to edit Group Hooks.
  • Make the UI consistent across Project / Group / Admin Hooks (at least on index pages) by extracting shared partials and DRY-ing up the code.
  • Add / update specs and improve code / missing translations around old code.

Screenshots

Comparing before / after of the webhooks pages for project / group / admin levels

Section Before After
Project Project_before Project_after
Group Group_before Group_after
Admin Admin_before Admin_after

New Group Hooks Edit page

(I wasn't really sure on the breadcrumbs naming so I reused what was in the other pages. Not sure if we have any guidelines about it) Group_edit

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports