Fix flakiness in Group SAML specs and some improvements
What does this MR do?
- Fixes "User already taken" issue by using a different SAML user for each test
- Fixes failure due to unsuccessful logout
- Moves removal of feature flags to the after block of the context where they were added
- Removes the workaround put in place due to the bug
https://gitlab.com/gitlab-org/gitlab/issues/35365
(now fixed) - Fixes an issue where screenshot captured is of the wrong screen due to UI steps in
after
block. Capybara captures screenshots in theafter
block. Anyafter
block in the test would run first causing the screenshot to be captured after the test'safter
block is run.
Closes #37308 (closed)
Fixes 1st part of #37374 (closed)
Conformity
Edited by Sanad Liaquat