Refactor WeightSelect to use gitlab-ui dropdown
Refactor WeightSelect to use gitlab-ui dropdown
This MR refactors the WeightSelect component to use GlDropdown instead of the jquery based weight_select.js.
GlDropdown doesn't perfectly match the old jquery component, but I tried to get it as close as possible.
Screenshots
Default state
Is unaffected by the refactor.
| Before | After |
|---|---|
 |
 |
Selecting weight
The visual style & spacing differs slightly, but should be solved when the new gitlab-ui dropdown is ready to replace the current implemenation.
| Before | After |
|---|---|
 |
 |
Active weight
Same as above, and GlDropdown is missing the checkmark icon on the selected item.
| Before | After |
|---|---|
 |
 |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Closes #12588 (closed)
Edited by 🤖 GitLab Bot 🤖