GitLab UI integration for version 123.10.0
What does this MR do and why?
This MR integrates accessibility changes from the GitLab UI GlTokenSelector component. The component was refactored to be a true accessible rich internet application (ARIA) combobox. Making this change will cause some tests to fail because they're using selectors not explicitly identified as breaking changes in semantic versioning.
References
- Upstream GitLab UI MR: gitlab-org/gitlab-services/design.gitlab.com!5174 (merged)
- Parent issue: gitlab-org/gitlab-services/design.gitlab.com#2215 (closed)
Screenshots or screen recordings
TODO: Add before
After update invite-members-demo-AFTER
How to set up and validate locally
- Pull branch and run
yarn installfrom within/gitlabdirectory to ensure you have the custom@gitlab/uipackage installed - Start
gdkand log in - Navigate to a project
- From the Project overview use the left nav Manage > Members to go to Project Members view
- Click the blue "Invite members" button in the top right
- This will open the Invite members modal. This modal typeahead uses
GlTokenSelector - Turn on the screen reader of your choosing to test. On a Mac, use Safari + VoiceOver as Chrome sometimes makes mistakes.
- Verify the typeahead is announced as a combobox and announces the listbox items correctly.
- Listbox items should be announced as "ITEM_NAME, selected, 1 of N"
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Trevor Pierce