Skip to content

Resolve "Finding vulnerability as dismissed before the action"

Dheeraj Joshi requested to merge 32959-dismissal-ux-improvement into master

What does this MR do?

Fixes Issue #32959 (closed).

Description

This is an UX improvement for dismissing a finding in the MR Security Widget. Due to this issue, the audit trail (on frontend) shows the finding as already dismissed before actually dismissing it.

This MR fixes the aforementioned issue by removing the message showing that it is already dismissed, and also removing the timestamp.

The fix is relying upon the timestamp of the dismissal. If there is no dismissal timestamp already present, we should assume that it has not been dismissed. Thus, removing ambiguous message for better UX.

Screenshots

Before After
image image
Also, the below screenshot is for the case when a finding has already been dismissed. No changes
Screenshot_2019-11-26_at_1.30.46_PM

Does this MR meet the acceptance criteria?

Conformity

Edited by Dheeraj Joshi

Merge request reports