Skip to content

Check that uploaded file content matches the file extension

Alex Pooley requested to merge ap-33785-file-integrity into master

What does this MR do?

References #33785 (closed)

Ensure that an uploaded file extension matches its content - backend only. Issues arise between mismatched 'Content-Type' and 'Content-Disposition' headers, as well as potential for security holes.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Michael Kozono

Merge request reports