Skip to content

Remove DeleteOrphanedGroups BBM

Abdul Wadoodrequested to merge
workloads/c5d46124990 into master

What does this MR do and why?

The DeleteOrphanedGroups batched background migration (BBM) spec is failing in https://gitlab.com/gitlab-org/gitlab/-/jobs/11439235448 because it depends on application code.

Specifically, the spec at ./spec/lib/gitlab/background_migration/delete_orphaned_groups_spec.rb:59 fails due to the state_metadata JSON schema validation in the Namespace model introduced in !198956 (merged). This validation doesn't work with the BBM because:

  1. BBM specs run on the schema version that finalized the migration
  2. Database changes are rolled back to that version, but application code changes (like validations) are not
  3. This violates the BBM isolation principle - BBMs should not depend on application code

Here we:

  • Remove DeleteOrphanedGroups batched background migration class and spec
  • Remove associated migration documentation
  • Clean up migration queue files that reference the BBM

This BBM was finalized in GitLab 18.0 and is causing test failures due to dependency on application code (state_metadata validation), violating BBM isolation principles.

References

!198956 (comment 2770965493)

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Relates to #573060 (closed)

Edited by Abdul Wadood

Merge request reports