Skip to content

feat(merge-request): visualize coverage delta on MR widget

Fabio Huser requested to merge siemens/gitlab:feat/merge-request-coverage-delta into master

What does this MR do?

This MR adds the coverage delta (difference between the coverage recorded on the source branch vs target branch) to the merge request view.

It is only visible if the coverage for both target/source branch was recorded. The coverage delta is coloured based on the type of change (increase/decrease).

While this feature is quite a minute detail on the merge request page, it is essential to quickly identify, if a merge request degrades the test coverage.

Replaces gitlab-foss!10722 (closed)

Closes #14405 (closed)

Screenshots

No change:

image

Coverage increased:

image

Coverage decreased:

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

documentation: I haven't found any existing documentation regarding visualisation of coverage on merge requests. Due to that and the fact that the coverage delta text is quite easy to understand, I didn't add any documentation.

UX: This MR implements a really basic version of the coverage delta visualisation, but I think this is good enough as an initial version. WDYT?

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Huser

Merge request reports