Skip to content

Modify default GKE OAuth Scopes

Tan Yee Jian requested to merge (removed):gke-oauth into master

What does this MR do?

Closes #22488 (closed). This MR allows Gitlab GKE cluster to access Google Cloud Registry private images by minimally allowing the following OAuth Scopes:

"oauthScopes": [
    "https://www.googleapis.com/auth/devstorage.read_only",
    "https://www.googleapis.com/auth/logging.write",
    "https://www.googleapis.com/auth/monitoring"
]

I am yet to test that it achieves the desired behaviour.

Edit: I have added the corresponding parameters in the test file, but this still does not guarantee that this feature works as expected. Appreciate any guidance on how to do so.

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Manual testing

See !20662 (comment 251914486) where @hfyngvason verified pulling from private Google Container Registry now works (and also that it does not work in master)

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading