Explicitly define exposed properties in popovers.vue
-
Please check this box if this contribution uses AI-generated content (including content generated by GitLab Duo features) as outlined in the GitLab DCO & CLA. As a benefit of being a GitLab Community Contributor, you receive complimentary access to GitLab Duo.
What does this MR do and why?
Explicitly exposes addPopovers and dispose from the popovers.vue component and removes the component from the vue-no-unused-properties.mjs exclude list.
-
addPopoversis used outside this component at app/assets/javascripts/popovers/index.js#L29. -
disposeis used outside this component at app/assets/javascripts/popovers/index.js#L50
The disconnect test of the popovers.vue component is refactored to use mocking mechanisms that don't rely on the underlying observer property of the component.
References
- Related issue: Address `vue/no-unused-properties` violations i... (#525757)
- Related epic: Address `vue/no-unused-properties` offenses (&17180)
How to set up and validate locally
- Verify that
app/assets/javascripts/popovers/components/popovers.vueis not in the.eslint_todo/vue-no-unused-properties.mjslist - Run
eslint app/assets/javascripts/popovers/components/popovers.vue
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Philipp Würsch