Skip to content

Explicitly define exposed properties in popovers.vue

What does this MR do and why?

Explicitly exposes addPopovers and dispose from the popovers.vue component and removes the component from the vue-no-unused-properties.mjs exclude list.

The disconnect test of the popovers.vue component is refactored to use mocking mechanisms that don't rely on the underlying observer property of the component.

References

How to set up and validate locally

  1. Verify that app/assets/javascripts/popovers/components/popovers.vue is not in the .eslint_todo/vue-no-unused-properties.mjs list
  2. Run eslint app/assets/javascripts/popovers/components/popovers.vue

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Philipp Würsch

Merge request reports

Loading