Skip to content

Refactor x509 signature tests

What does this MR do and why?

Problem:

Tests from files:

  • spec/lib/gitlab/x509/signature_sigstore_spec.rb
  • spec/lib/gitlab/x509/signature_spec.rb

have a lot of duplication and are very difficult to modify.

Solution:

  • Remove duplication
  • Extract common parts into shared_examples

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #553481

Edited by Vasilii Iakliushin

Merge request reports

Loading