Skip to content

Ensure assets get recompiled if cached-assets-hash.txt is empty

What does this MR do and why?

This backports !206131 (merged) to 18-4-stable-ee.

We noticed the canary deployment had stale assets. It appears the downloaded cached-assets-hash.txt was 0 bytes (https://dev.gitlab.org/gitlab/gitlab-ee/-/jobs/30827988#L172). This appeared to have been empty because the cache:assets-hash job failed to upload the build.env artifacts due to rate limiting errors (https://dev.gitlab.org/gitlab/gitlab-ee/-/jobs/30827983), and that job is allowed to fail.

Relates to gitlab-com/gl-infra/production#20599 (closed)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

  • This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch.
  • The MR that fixed the bug on the default branch has been deployed to GitLab.com (not applicable for documentation or spec changes).
  • The MR title is descriptive (e.g. "Backport of 'title of default branch MR'"). This is important, since the title will be copied to the patch blog post.
  • Required labels have been applied to this merge request
  • Set the milestone of the merge request to match the target backport branch version.
  • This MR has been approved by a maintainer (only one approval is required).
  • Ensure the e2e:test-on-omnibus-ee job has either succeeded or been approved by a Software Engineer in Test.

Note to the merge request author and maintainer

If you have questions about the patch release process, please:

Edited by Stan Hu

Merge request reports

Loading