Skip to content

Fix broken anchor for security report help page

What does this MR do?

Current Problem

The data variable coming from the Backend (data-vulnerability-feedback-help-path) holds the following value /help/user/application_security/index#interacting-with-the-vulnerabilities.

As you can see, it's already having a fragment identifier and the SolutionCard component is appending another fragment id (a wrong one) instead of replacing it.

Due to this, the complete URL looks like https://gitlab.com/help/user/application_security/index#interacting-with-the-vulnerabilities#solutions-for-vulnerabilities which is wrong.

Unlike Projects & Groups Security Dashboard, the data variable for Pipeline Security Dashboard doesn't contain any fragment url - /help/user/application_security/index initially.

Current Fix

To fix the aforementioned problems, this MR does the following things

  1. Make sure the fragment Identifier is appended correctly - removing the previous fragment if present and adding new.
  2. Use the correct identifier solutions-for-vulnerabilities-auto-remediation.

Screenshots

Please refer the URL at the bottom left of the screenshot, sorry if that's difficult to read.

OLD NEW
Screenshot_2019-11-21_at_6.53.57_PM Screenshot_2019-11-21_at_4.58.37_PM

Does this MR meet the acceptance criteria?

Conformity

Closes #35616 (closed)

Edited by Dheeraj Joshi

Merge request reports