Skip to content

Draft: Cleanup Duo gRPC connection juggling

Mikhail Mazurskiyrequested to merge
ash2k/cleanup-duo-grpc into master

What does this MR do and why?

  1. Replace the mutex with sending from a single goroutine.
  2. Handle WebSocket close frames and close the outbound gRPC connection cleanly in that case.
  3. Abort the outbound gRPC connection when an error is encountered by canceling the context of the work group.
  4. TODO abort the inbound WebSocket connection when an error is encountered by returning from the handler.

References

Relates to Duo Agent: Can we remove thread safe locking of... (#568969).

Screenshots or screen recordings

Before After

How to set up and validate locally

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports