Skip to content

Refactor gl dropdown.js

Marvin Karegyeya requested to merge nuwe1/gitlab:Refactor-gl_dropdown.js into master

What does this MR do?

This MR is a follow-up improvement that aims to convert all constructor functions in the gl_dropdown.js file to ES6 Class after having a discussion on this !19983 (merged) that aimed at removing just the IIFEs from the file and !20166 (merged) which aimed at replacing var with let and const

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marvin Karegyeya

Merge request reports