Open newly created Jira issue for vulnerability in same tab
What does this MR do and why?
Open newly created Jira issue for vulnerability in same tab
Because the issue creation happens in the background and we need to poll for it, opening the link in a new tab is not a direct user interaction and therefore it's often blocked as a pop-up in modern browsers.
References
Related #441954 (closed)
Screenshots or screen recordings
How to set up and validate locally
- Create setup where findings are introduced in an MR. E.g. Import https://gitlab.com/gitlab-examples/security/security-reports, comment sast CI jobs, run pipeline on master, uncomment sast CI jobs in a new MR
- Setup Jira integration for your project: https://docs.gitlab.com/integration/jira/ (I can help with this if you're having trouble)
- Dismiss a finding first in the MR security reports widget (this is needed to create a vulnerability for the finding, because the create jira issue mutation only works for vulnerabilities)
- Open finding in modal and click "Create Jira issue". It should start loading, it is possible this takes a long time to load due to reactive caching (this long wait will be fixed with #568900)
- Validate the button stays loading as long as we're polling. In the end you should be redirected in same tab to the Jira ticket.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Lorenz van Herwaarden