Skip to content

Hide secrets manager settings behind feature flag instead of just the license

What does this MR do and why?

This is a bug fix to make sure that the secrets manager settings is hidden behind the secrets_manager feature flag, and not just the license. Owners should be able to make changes, while Maintainers have view-only permissions.

References

This is a follow-up to #555427 (comment 2729188083).

Screenshots or screen recordings

FF enabled (Maintainer) FF enabled (Owner)
ff_enabled_maintainer ff_enabled_owner

In the following screenshots, the secrets manager settings is not rendered.

FF enabled (feature not included in license) FF disabled
ff_enabled_no_license ff_disabled

How to set up and validate locally

Setup

  1. Upload an Premium or Ultimate license.
  2. Set up openbao on your gdk.
  3. Enable the secrets manager on gdk.

Verification

  1. Go to your project settings (Settings > General) and expand Visibility, project features, permissions to view the permissions table. Verify that the settings is hidden when secrets_manager FF is disabled.

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mireya Andres

Merge request reports

Loading