Skip to content

Conditionally show policy violation vuln filter

Alexander Turinskerequested to merge
549786-add-dismiss-vulnerability-report-policy-filtering into master

What does this MR do and why?

Conditionally show policy violation vuln filter for the vulnerability report at all levels except pipeline

  • with feature flag, show policy violation activity filter in the activity dropdown

What does this MR not do and why?

_ it does not apply the filter to the backend requests because that work is not complete yet

References

Screenshots or screen recordings

Scenario Screenshot
Before / FF off FF_off
Project ff_on_-_project
Group ff_on_-_group
Instance ff_on_-_instance

How to set up and validate locally

  1. Upload a GitLab Ultimate license
  2. Enable the security_policy_approval_warn_mode feature flag in http://gdk.test:3000/rails/features
  3. Navigate to a project with vulnerabilities => Secure => Vulnerability report
  4. Verify the user can see an activity filter for policy violations
  5. Navigate to a group with a project with vulnerabilities => Secure => Vulnerability report
  6. Verify the user can see an activity filter for policy violations
  7. Navigate to the user's 'Your work' section via search bar in sidebar => Security => Vulnerability report (or http://gdk.test:3000/-/security/vulnerabilities/)
  8. Verify the user can see an activity filter for policy violations

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #549786

Edited by Alexander Turinske

Merge request reports