Allow users to delete secrets manager permissions
What does this MR do and why?
Requires the secrets_manager feature flag.
This allows Owners to delete existing secrets manager permissions from the settings. Maintainers can view these settings, but they cannot delete permissions.
Currently, there is a bug where fetching the secrets manager permissions list is only restricted for Owners. Because the query fails, the Maintainers' view will show an empty table (accompanied by an error message via an alert). This will be addressed in a follow-up; please see #538090 (comment 2727081587) for further discussion.
References
Implements #538090 (closed).
Screenshots or screen recordings
| Owner View (can delete) | Maintainer View (cannot delete) |
|---|---|
| owner | maintainer |
How to set up and validate locally
Setup
- Upload an Premium or Ultimate license.
- Set up openbao on your gdk.
- Enable the secrets manager on gdk.
Verification
- Go to your project settings (Settings > General) and expand Visibility, project features, permissions to view the permissions table.
- Create permissions and then verify that you can delete them.
- Deleting requires the user to confirm via a confirmation modal first
- There should be a toast message that provides feedback that the deletion is successful.
MR acceptance checklist
Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.
Edited by Mireya Andres