Skip to content

Redirect locked Group SSO users to SSO page instead of 500 error

James Edwards-Jones requested to merge jej/fix-2fa-reset-with-group-sso into master

What

Redirects locked users to the SSO page instead of generic sign in when accessed via Group SAML.

This avoids a 500 error caused by attempting to access a missing captcha_enabled? method that is not present in the OmniauthCallbacksController, and instead displays an account locked flash message.

Why

Users were getting a 500 error after incorrectly entering a 2FA code many times.

One part of solving #34998 (closed)

Next steps

  • The SSO page still redirects to generic sign in via route_not_found because the user is locked
  • Need to fix root cause of 2FA lockouts

Screenshots

Before After
screenshot_2020-01-28-11_22_44 screenshot_2020-01-28-10_49_08

Acceptance criteria

Availability and Testing

Edited by James Edwards-Jones

Merge request reports