Skip to content

Adds border radii to more components, fix for increased border radii

Sascha Eggenbergerrequested to merge
increase-border-radius-of-more-components into master

What does this MR do and why?

Adds some bugfixes for the increased border radii from base to lg:

  • Tree
  • File wrapper
  • File diff wrapper

Adds increased border radii to:

  • Board lane (scoped)
  • Pending comment (doesn't need to be scoped)
  • User activity graph (doesn't need to be scoped)

Fixes optical spacing between buttons by decreasing it slightly:

  • GlButton

With the

Screenshots or screen recordings

Before After
Increased border radii
board_before board_after
pending_before pending_after
before_graph after_graph
Bugfixes
discussion_before discussion_after
tree_before tree_after
file_holder_before file_holder_after
GlButton decreased spacing
before after
before2 after2

How to set up and validate locally

  1. https://gdk.test:3000/flightjs/Flight
  2. https://gdk.test:3000/flightjs/Flight/-/merge_requests/4/diffs
  3. https://gdk.test:3000/flightjs/Flight/-/commit/7dc27ded83e64ac6f1f295dcd1195a43375dae76
  4. https://gdk.test:3000/admin
  5. https://gdk.test:3000/flightjs/Flight/-/jobs/867
  6. https://gdk.test:3000/flightjs/Flight/-/boards
  7. https://gdk.test:3000/root

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #548836 (closed)

Edited by Sascha Eggenberger

Merge request reports