Migrate to use shared validity refresh FF

Samantha Mingrequested to merge
560598-use-shared-ff-for-validity-refresh into master

What does this MR do and why?

We want to use the shared FF instead. This MR deletes the old FF and all its references and usages.

- validity_refresh
+ secretDetectionValidityChecksRefreshToken

All existing UI/UX remains the same

FF on - has validity refresh FF off - no validity refresh
image image

References

Screenshots or screen recordings

Before After

How to set up and validate locally

  1. Enable FF: validity_checks_security_finding_status http://gdk.test:3000/rails/features/validity_refresh
  2. Enable FF: validity_checks http://gdk.test:3000/rails/features/validity_checks
  3. Enable validity checks: https://docs.gitlab.com/user/application_security/vulnerabilities/validity_check/#enable-validity-checks
  4. Clone this project: https://gitlab.com/gitlab-org/govern/threat-insights-demos/verify-validity-refresh-check
  5. Run a successful pipeline
  6. Visit the vulnerability report page and select a vulnerability
  7. Toggle the FF secretDetectionValidityChecksRefreshToken to see or not see the validity check feature

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #560598 (closed)

Edited by Samantha Ming

Merge request reports