Skip to content

Cleanup unused GLQL source in Search Service

Alisa Frunzarequested to merge
544820-cleanup-unused-code into master

What does this MR do and why?

Originally, source: 'GLQL' was introduced to skip querying notes for GLQL requests since it was increasing query time and overall we didn't use this functionality.

After we converted GLQL finder to more generic Advanced Work Items Finder (MR1, MR2), we also switched to using ::Search::Elastic::Relation.new that requires accessing ::Search::Elastic::WorkItemQueryBuilder directly (instead of using ::SearchService.new). This way we don't need to pass source: 'GLQL' param anymore since we can directly control the flow and decide not to query notes by to sending options[:related_ids].

This MR cleans up unused code introduced in this MR !194737 (merged).

References

Screenshots or screen recordings

Before After

How to set up and validate locally

  • All tests should pass ✅
  • Nothing should change for the advanced search page since it never passed source field
  • Noting should change for GLQL queries since we already removed source param in the previous MR

MR acceptance checklist

Evaluate this MR against the MR acceptance checklist. It helps you analyze changes to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #544820 (closed)

Edited by Alisa Frunza

Merge request reports