Remove Knative CRDs by group name instead of individually
What does this MR do?
Helm does not uninstall CustomResourceDefinitions (CRDs) from Kubernetes. So we had to track a list of existing CRDs to be deleted after Knative gets uninstalled.
This MR refactors the code to, instead of tracking a list of CRDs (big list), we track a list of these CRDs api-groups (much smaller list, less likely to change). With the list of api-groups, we can get the CRDs associated with them, then delete those CRDs.
Addresses follow-up ~backstage issue: #30562 (closed)
See the list of api-groups found for Knative current version (0.7.0)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖